[JENKINS-72622] Rename CloudSet query parameter to avoid conflict #9198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a SpotBugs issue introduced left to address, btw |
|
@Dohbedoh , Just a heads-up in case the notification slipped by about the SpotBugs that @NotMyFault mentioned. :) |
timja
approved these changes
May 15, 2024
NotMyFault
approved these changes
May 18, 2024
There was a problem hiding this comment.
/label ready-for-merge
This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!
comment-ops-bot
bot
added
the
ready-for-merge
krisstern
pushed a commit
to krisstern/jenkins
that referenced
this pull request
May 24, 2024
…nkinsci#9198) * [JENKINS-72622] Rename CloudSet query parameter to avoid conflict * [JENKINS-72622] Address SpotBugs warning (cherry picked from commit eb65336)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-72622.
The parameter
typeis quite generic. For example it conflict with one of the AmazonEC2Cloud form attribute. proposing to use more specici attributecloudDescriptorNameto fix this and also avoid conflict in the future.Testing done
ec2-plugin)kubernetes-plugin)docker-plugin)Proposed changelog entries
typetocloudDescriptorNameto avoid conflicts in Clouds implementations.Proposed upgrade guidelines
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist